| title: | Re patch v2 ALSA rawmidi fix the get ne |
|
On Thu, Sep 09, 2010 at 09:44:52AM +0200, Clemens Ladisch wrote:
Dan Carpenter wrote:
If we pass in a device which is higher than SNDRV_RAWMIDI_DEVICES then
this function just returns device + 1 which isnt helpful. Ive
modified it to return -EINVAL instead.
Also Smatch complains because the "device + 1" could be an integer
overflow. Its harmless,
It would result in device==INT_MIN, which would make the while loop go
through 2^31 values before finding the first MIDI device.
Oh crap. Youre right. For some reason I got mixed up.
regards,
dan carpenter
Regards,
Clemens
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
rel="nofollow" mailman.alsa-project.org/mailman/listinfo/alsa-devel mailman.alsa-project.org/mailman/listinfo/alsa-devel
|
