| title: | Re RFC v14 rc2 PATCH 3 7 sysvipc shm che |
|
Serge E. Hallyn wrote:
Quoting Oren Laadan (orenl@xxxxxxxxxxxxxxx):
...
int cr_write_ipc(struct cr_ctx *ctx, struct nsproxy *nsproxy)
{
- return 0;
+ return cr_write_ipc_shm(ctx, nsproxy- ipc_ns);
}
What is the plan for implementing support for nested ipc namespaces,
since all ipc data is currently stored as a single global checkpoint
property before the task data?
Are you figuring youll just do cr_write_ipc_shm() for all nsproxies
which are part of the checkpoint image, and store an ipc_ns id
or nsproxy id alongside it, so that at restart you just recreate all
the ipc namespaces ahead of time, then attach the tasks to their
target namespaces as they are created?
Just wondering... as it stands the code looks more like it *wants*
to be targeted at only one ipcns per checkpoint image.
Good question (i.e. this deserves a commentin the patch description...)
The plan is to call cr_write_ipc() for each ipc namespace as soon as
we discover it, and deposit in the objhash. The second encounter of the
same namespace will simply skip.
This fits well with restart, because we will encounter the new objref
in in teh context of the right task, i.e. one that has that namespace
in its nsproxy, and all operations (e.g. shmget) will take place in
the correct namespace.
So, yes, this will move from the global section into a per-task
nsproxy-contents section.
Oren.
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
rel="nofollow" lists.linux-foundation.org/mailman/listinfo/containers lists.linux-foundation.org/mailman/listinfo/containers
|
